Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch widget visual fixes #150

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Conversation

giannissc
Copy link
Contributor

I have fixed the visuals of the knob in the hot (bigger and lighter), active (smaller and darker) and idle configuration.

The knob would also jump if the dragging started from the negative area of the widget and it seemed kinda jerky.

I have also disabled some of print statement in other places to cleanup the terminal output

@giannissc
Copy link
Contributor Author

I have made another (final) PR for the switch widget with some last minute visual changes to it. I will be pushing the progress bar and slider next! @Philipp-M

@Philipp-M
Copy link
Contributor

Hmm for me this regresses the dragging. Previously dragging with the mouse worked as expected, now it's kinda janky (it's much faster than the mouse pointer, and lags behind).

@giannissc
Copy link
Contributor Author

Good catch. I rethought the implementation and it should be must smoother now. Let me know how you like it! @Philipp-M

@giannissc giannissc enabled auto-merge November 23, 2023 19:20
Copy link
Contributor

@nicoburns nicoburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if dragging is even really needed for the switch, but it's all working very smoothly for me with the latest version.

@giannissc giannissc added this pull request to the merge queue Nov 23, 2023
Merged via the queue into linebender:main with commit 9b84691 Nov 23, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants