Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies (notably wgpu and vello) #177

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

Philipp-M
Copy link
Contributor

While reviewing #176, I had a deadlock in

let surface_texture = surface

(see comments there)

This updates vello and wgpu (to current git HEAD where this deadlock cannot occur, since the relevant lines in wgpu are gone).

Since the surface is lifetime bounded now, it needs a little bit different initialization (the reason why it's already done in MainState::new).

@xorgy
Copy link
Member

xorgy commented Feb 24, 2024

LGTM. I bumped the rest of the things in Cargo.lock and popped that on the branch.
nvm, that requires bumping the CI Rust toolchain to 1.75.

@xorgy xorgy self-requested a review February 24, 2024 00:02
@xorgy xorgy force-pushed the update-dependencies branch from 6e2e1c4 to 1beeefe Compare February 24, 2024 00:03
@Philipp-M
Copy link
Contributor Author

that requires bumping the CI Rust toolchain to 1.75.

I don't think we try to keep MSRV low currently (I think at least probably until TAIT is stabilized). So why not.

@Philipp-M Philipp-M added this pull request to the merge queue Feb 24, 2024
Merged via the queue into linebender:main with commit f2454eb Feb 24, 2024
14 checks passed
@Philipp-M Philipp-M deleted the update-dependencies branch February 24, 2024 11:21
@xorgy
Copy link
Member

xorgy commented Feb 26, 2024

So why not.

Maybe warrants its own little PR so it's clear that's what's going on.

@DJMcNab DJMcNab mentioned this pull request Mar 15, 2024
DJMcNab added a commit to DJMcNab/xilem that referenced this pull request Mar 15, 2024
github-merge-queue bot pushed a commit that referenced this pull request Mar 19, 2024
* Use released versions of Vello and wgpu

Partially reverts #177

Fixes #189

* Revert auto format of comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants