Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comment about make_trace_span #609

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Add comment about make_trace_span #609

merged 2 commits into from
Sep 24, 2024

Conversation

PoignardAzur
Copy link
Contributor

No description provided.

jaredoconnell
jaredoconnell approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. Is there a tracking issue on GitHub?

@DJMcNab
Copy link
Member

DJMcNab commented Sep 24, 2024

We should at the very least point at rust-lang/rust#63084. I don't think there's that much value in making an issue for this, given that it would be unactionable.
But if anyone runs into this in future, they can subscribe to that issue to get the relevant reminder.

@PoignardAzur PoignardAzur added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit d4f3fc8 Sep 24, 2024
17 checks passed
@PoignardAzur PoignardAzur deleted the rewrite_make_trace_span branch September 24, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredoconnell jaredoconnell jaredoconnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PoignardAzur @DJMcNab @jaredoconnell