Add basic window control #670
Conversation
melix99
force-pushed
the
window-control
branch
from
ce36ad1
to
f5578f8
Compare
masonry/src/widget/window_handle.rs
Outdated
|
|
||
| /// A titlebar area widget. | ||
| /// | ||
| /// An area that can be dragged to move the window. |
There was a problem hiding this comment.
This needs some more documentation about how it's expected to be used.
There was a problem hiding this comment.
Done, I hope it's clear enough.
| ctx.place_child(child, Point::ORIGIN); | ||
| bc.constrain(size) | ||
| } | ||
| None => bc.max(), |
There was a problem hiding this comment.
I'd expect this to impose a max height by default.
There was a problem hiding this comment.
See my reply below. This is supposed to be just a container, so users of this widget should wrap it in their titlebar custom widget. So, I think that just filling the constrain is the right thing to do.
| fn layout(&mut self, ctx: &mut LayoutCtx, bc: &BoxConstraints) -> Size { | ||
| match self.child.as_mut() { | ||
| Some(child) => { | ||
| let size = ctx.run_layout(child, bc); |
There was a problem hiding this comment.
Maybe similarly here, although I can see arguments for not doing so
| fn paint(&mut self, _ctx: &mut PaintCtx, _scene: &mut Scene) {} | ||
|
|
||
| fn accessibility_role(&self) -> Role { | ||
| Role::GenericContainer |
There was a problem hiding this comment.
I suspect this is right, but I'm not certain
There was a problem hiding this comment.
I think it's right, since this is a container. The actual titlebar should have the Role::TitleBar.
| } | ||
| } | ||
|
|
||
| fn paint(&mut self, _ctx: &mut PaintCtx, _scene: &mut Scene) {} |
There was a problem hiding this comment.
Nothing drawn at all here feels a bit weird
There was a problem hiding this comment.
See my reply below. This is supposed to be just a container, so users of this widget should wrap it in their titlebar custom widget and do their drawing in there.
|
Well, I guess I should've included more information on how the The |
melix99
force-pushed
the
window-control
branch
from
f5578f8
to
00b7aac
Compare
melix99
force-pushed
the
window-control
branch
from
00b7aac
to
bb4d08f
Compare
This is the first merge-able part of #606.
It allows to implement custom CSDs via window management signals and a new
WindowHandlewidget which is useful to implement a custom titlebar.