Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pair image with copyright notice in http_cats example. #895

Merged
merged 3 commits into from
Mar 18, 2025

Conversation

platlas
Copy link
Contributor

@platlas platlas commented Mar 18, 2025

While on slow internet connection I noticed that copyright notice is conflicting with the spinner:
http_cat-screenshot

So I paired the image with the copyright notice to display it only when image is loaded. I hope this is not complicating the example code.

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I moved where the new variable is defined slightly

@DJMcNab DJMcNab enabled auto-merge March 18, 2025 15:35
@DJMcNab DJMcNab added this pull request to the merge queue Mar 18, 2025
Merged via the queue into linebender:main with commit e1907a2 Mar 18, 2025
18 checks passed
@platlas platlas deleted the http_cat-attribution-display branch March 18, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants