Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(no-unlocalized-strings): merge visitors #59

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

timofei-iatsenko
Copy link
Collaborator

@timofei-iatsenko timofei-iatsenko commented Oct 11, 2024

merge Literal and TemplateLiteral visitors into one. Inline methods which was extracted to be used in these two visitors.

@timofei-iatsenko timofei-iatsenko changed the title ref(no-unlocalized-strings): merge visitors refactor(no-unlocalized-strings): merge visitors Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 98.70130% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.44%. Comparing base (b36edbf) to head (3cd074f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/rules/no-unlocalized-strings.ts 98.70% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   95.91%   96.44%   +0.52%     
==========================================
  Files          10       10              
  Lines         490      450      -40     
  Branches      162      156       -6     
==========================================
- Hits          470      434      -36     
+ Misses         20       16       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-bodnar andrii-bodnar merged commit 4495728 into main Oct 11, 2024
5 of 6 checks passed
@andrii-bodnar andrii-bodnar deleted the rule-refactoring branch October 11, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants