fix(core): don't crash on escaped unicode symbols in messages (#1692)

package.json

@@ -99,7 +99,7 @@
     {
       "path": "./packages/core/dist/index.mjs",
       "import": "{ i18n }",
-      "limit": "2 kB"
+      "limit": "3 kB"
     },
     {
       "path": "./packages/detect-locale/dist/index.mjs",

packages/core/package.json

@@ -54,7 +54,8 @@
   ],
   "dependencies": {
     "@babel/runtime": "^7.20.13",
-    "@lingui/message-utils": "4.2.0"
+    "@lingui/message-utils": "4.2.0",
+    "unraw": "^2.0.1"
   },
   "devDependencies": {
     "@lingui/jest-mocks": "*",

packages/core/src/interpolate.test.ts

@@ -177,4 +177,11 @@ describe("interpolate", () => {
       })
     })
   })
+
+  it("should not crash on a unicode sequences", () => {
+    const cache = compile("Hey {name}!")
+    expect(interpolate(cache, "en", [])({ name: "Joe\\xaa" })).toEqual(
+      "Hey Joeª!"
+    )
+  })
 })

packages/core/src/interpolate.ts

@@ -1,6 +1,7 @@
 import { CompiledMessage, Formats, Locales, Values } from "./i18n"
 import { date, number, plural } from "./formats"
 import { isString } from "./essentials"
+import unraw from "unraw"
 
 export const UNICODE_REGEX = /\\u[a-fA-F0-9]{4}|\\x[a-fA-F0-9]{2}/g
 
@@ -92,8 +93,12 @@ export function interpolate(
     }
 
     const result = formatMessage(translation)
-    if (isString(result) && UNICODE_REGEX.test(result))
-      return JSON.parse(`"${result.trim()}"`)
+    if (isString(result) && UNICODE_REGEX.test(result)) {
+      // convert raw unicode sequences back to normal strings
+      // note JSON.parse hack is not working as you might expect https://stackoverflow.com/a/57560631/2210610
+      // that's why special library for that purpose is used
+      return unraw(result.trim())
+    }
     if (isString(result)) return result.trim()
     return result
   }

yarn.lock

@@ -2729,6 +2729,7 @@ __metadata:
     "@lingui/jest-mocks": "*"
     "@lingui/message-utils": 4.2.0
     unbuild: ^1.1.2
+    unraw: ^2.0.1
   languageName: unknown
   linkType: soft
 
@@ -14363,6 +14364,13 @@ __metadata:
   languageName: node
   linkType: hard
 
+"unraw@npm:^2.0.1":
+  version: 2.0.1
+  resolution: "unraw@npm:2.0.1"
+  checksum: af9a9d2f6e420cb4f52fe2f1f5982e6b0be95da640d6ae8d6d9ff631d864771793cb9fe7e2a16ef1ce631b94065f4438e7bd7f1701076fc69296edc4e704d42f
+  languageName: node
+  linkType: hard
+
 "untyped@npm:^1.2.2":
   version: 1.2.2
   resolution: "untyped@npm:1.2.2"