feat: enable importAttributes and explicitResourceManagement for extr…

…actor feat: bump minimal @babel/parser version
lingui · Oct 4, 2024 · 98b6ec7 · 98b6ec7
1 parent 6b77971
commit 98b6ec7
Show file tree

Hide file tree

Showing 6 changed files with 271 additions and 1,499 deletions.
diff --git a/packages/babel-plugin-extract-messages/package.json b/packages/babel-plugin-extract-messages/package.json
@@ -41,7 +41,7 @@
   },
   "devDependencies": {
     "@babel/core": "^7.21.0",
-    "@babel/traverse": "7.20.12",
+    "@babel/traverse": "^7.20.12",
     "@babel/types": "^7.20.7",
     "@lingui/jest-mocks": "*",
     "unbuild": "2.0.0"

diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -50,7 +50,7 @@
   "dependencies": {
     "@babel/core": "^7.21.0",
     "@babel/generator": "^7.21.1",
-    "@babel/parser": "^7.21.2",
+    "@babel/parser": "^7.22.0",
     "@babel/runtime": "^7.21.0",
     "@babel/types": "^7.21.2",
     "@lingui/babel-plugin-extract-messages": "4.11.4",

diff --git a/packages/cli/src/api/__snapshots__/compile.test.ts.snap b/packages/cli/src/api/__snapshots__/compile.test.ts.snap
@@ -10,7 +10,7 @@ exports[`createCompiledCatalog options.namespace should compile with global 1`]
 
 exports[`createCompiledCatalog options.namespace should compile with json 1`] = `{"messages":{"key":["Hello ",["name"]]}}`;
 
-exports[`createCompiledCatalog options.namespace should compile with ts 1`] = `/*eslint-disable*/import type{Messages}from"@lingui/core";export const messages=(JSON.parse("{\\"key\\":[\\"Hello \\",[\\"name\\"]]}")as Messages);`;
+exports[`createCompiledCatalog options.namespace should compile with ts 1`] = `/*eslint-disable*/import type{Messages}from"@lingui/core";export const messages=JSON.parse("{\\"key\\":[\\"Hello \\",[\\"name\\"]]}")as Messages;`;
 
 exports[`createCompiledCatalog options.namespace should compile with window 1`] = `/*eslint-disable*/window.test={messages:JSON.parse("{\\"key\\":[\\"Hello \\",[\\"name\\"]]}")};`;
 

diff --git a/packages/cli/src/api/extractors/babel.ts b/packages/cli/src/api/extractors/babel.ts
@@ -159,7 +159,10 @@ const extractor: ExtractorType = {
     const parserOptions = ctx.linguiConfig.extractorParserOptions
 
     // https://babeljs.io/docs/en/babel-parser#latest-ecmascript-features
-    const parserPlugins: ParserPlugin[] = []
+    const parserPlugins: ParserPlugin[] = [
+      "importAttributes", // stage3
+      "explicitResourceManagement", // stage3,
+    ]
 
     if (
       [/\.ts$/, /\.mts$/, /\.cts$/, /\.tsx$/].some((r) => filename.match(r))

diff --git a/packages/macro/package.json b/packages/macro/package.json
@@ -74,9 +74,9 @@
     "babel-plugin-macros": "2 || 3"
   },
   "devDependencies": {
-    "@babel/core": "7.20.12",
-    "@babel/parser": "7.20.15",
-    "@babel/traverse": "7.20.12",
+    "@babel/core": "^7.20.12",
+    "@babel/parser": "^7.20.15",
+    "@babel/traverse": "^7.20.12",
     "@types/babel-plugin-macros": "^2.8.5",
     "prettier": "2.8.3",
     "tsd": "^0.26.1",