Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): don't crash on escaped unicode symbols in messages #1692

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

timofei-iatsenko
Copy link
Collaborator

Description

Fixes. Unfortunately, it slightly increases a bundle size (for 800bytes)
#1691

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Jun 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2023 10:20am

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 1.44 KB (0%)
./packages/detect-locale/dist/index.mjs 721 B (0%)
./packages/react/dist/index.mjs 1.59 KB (0%)
./packages/remote-loader/dist/index.mjs 7.24 KB (0%)

@andrii-bodnar andrii-bodnar linked an issue Jun 7, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09 🎉

Comparison is base (cf16165) 75.72% compared to head (2aaceea) 75.82%.

❗ Current head 2aaceea differs from pull request most recent head 4fe9bf1. Consider uploading reports for the commit 4fe9bf1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1692      +/-   ##
==========================================
+ Coverage   75.72%   75.82%   +0.09%     
==========================================
  Files          79       79              
  Lines        2039     2039              
  Branches      524      524              
==========================================
+ Hits         1544     1546       +2     
+ Misses        379      378       -1     
+ Partials      116      115       -1     
Impacted Files Coverage Δ
packages/core/src/interpolate.ts 90.24% <100.00%> (+4.87%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timofei-iatsenko
Copy link
Collaborator Author

@andrii-bodnar i have no idea why release-workflow-test failed. Let's just restart it may be it helps.

@andrii-bodnar
Copy link
Contributor

@thekip I restarted it a couple of times, still failing 😬

@andrii-bodnar andrii-bodnar merged commit 461c2fc into lingui:main Jun 7, 2023
@timofei-iatsenko timofei-iatsenko deleted the fix/unicode-sequences branch June 7, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

interpolate crashes on some specific strings
2 participants