Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable importAttributes and explicitResourceManagement for extractor #2009

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

timofei-iatsenko
Copy link
Collaborator

@timofei-iatsenko timofei-iatsenko commented Aug 20, 2024

Description

Enable importAttributes and explicitResourceManagement parser plugins, because they are stage3 now and should be supported out of the box by lingui extractor

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes #2003

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 9:32am

Copy link

github-actions bot commented Aug 20, 2024

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.88 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.68 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

@andrii-bodnar andrii-bodnar added the ↻ awaiting rebase Rebase is needed due to conflicts label Sep 6, 2024
@timofei-iatsenko
Copy link
Collaborator Author

@andrii-bodnar rebased

@andrii-bodnar
Copy link
Contributor

@vonovak
Copy link
Collaborator

vonovak commented Sep 24, 2024

Just wondering, is this a preparation for future use of these features or what's the reason for this? I assume this doesn't influence consumers in any way, it's just for the tooling that's included in the lingui cli?

@timofei-iatsenko
Copy link
Collaborator Author

We stated in the docs that lingui extractor should understand out of the box valid ecmascript + stage3 features. It's written there

These 2 features became stage3 recently and our extractor fail on them but should not.

…actor

feat: bump minimal @babel/parser version
@timofei-iatsenko
Copy link
Collaborator Author

@andrii-bodnar all checks are green. Could be merged and deplyed in v4. Apologize that this took so long to finish.

@andrii-bodnar andrii-bodnar merged commit c20ce12 into main Oct 9, 2024
15 checks passed
@andrii-bodnar andrii-bodnar deleted the feature/add-stage-3-features branch October 9, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lingui extract ignores babel config
3 participants