-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable importAttributes and explicitResourceManagement for extractor #2009
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
bf026fe
to
6482e72
Compare
6482e72
to
7d1bdd7
Compare
@andrii-bodnar rebased |
@timofei-iatsenko the CI has failed, please check - https://github.com/lingui/js-lingui/actions/runs/10980398987/job/30486125563?pr=2009 |
7d1bdd7
to
0a93811
Compare
Just wondering, is this a preparation for future use of these features or what's the reason for this? I assume this doesn't influence consumers in any way, it's just for the tooling that's included in the lingui cli? |
We stated in the docs that lingui extractor should understand out of the box valid ecmascript + stage3 features. It's written there These 2 features became stage3 recently and our extractor fail on them but should not. |
…actor feat: bump minimal @babel/parser version
492659d
to
98b6ec7
Compare
@andrii-bodnar all checks are green. Could be merged and deplyed in v4. Apologize that this took so long to finish. |
Description
Enable
importAttributes
andexplicitResourceManagement
parser plugins, because they are stage3 now and should be supported out of the box by lingui extractorTypes of changes
Fixes #2003
Checklist