refactor(macro): split js (core) and jsx (react) macro

[timofei-iatsenko]

#1361

@Martin005 @andrii-bodnar please take a look here. I want to get feedback before i continue.

Overview:

graph LR
    core("@lingui/core/macro") --> lib("@lingui/macro-lib")
    react("@lingui/react/macro") --> lib
    macro("@lingui/macro") --> react
    macro --> core

Loading

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
js-lingui	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 1, 2023 at 0:08AM (UTC)

[github-actions]

size-limit report 📦

Path	Size
./packages/core/build/esm/index.js	1.72 KB (0%)
./packages/detect-locale/build/esm/index.js	812 B (0%)
./packages/react/build/esm/index.js	1.79 KB (0%)
./packages/remote-loader/build/esm/index.js	7.25 KB (0%)

[andrii-bodnar]

Looks interesting, but I don't really like the nascence of the new package, can we avoid it? Previously we discussed it and agreed that it was possible

[timofei-iatsenko]

Looks interesting, but I don't really like the nascence of the new package, can we avoid it? Previously we discussed it and agreed that it was possible

No. Look at the graph i wrote in the description.

Why you so don't like introducing new packages? It's the way how it works. It's internal and nobody should care.
Look at the formatjs or jest packages.

[andrii-bodnar]

Sure, I saw the graph. I can't say that I don't like new packages, but I prefer not to introduce new "entities" if possible and there is no urgent need

If it's inevitable, it'll be so 🤷‍♂️

[andrii-bodnar]

The most I worrying here about - is the potential @lingui/core bundle size increase

[timofei-iatsenko]

There would be no bundle size increase (the macro is not bundled), but installation size of @lingui/coreand @lingui/react would increase. For users who use macro nothing will be changed, installation size of all packages would be the same. For users who not using macro - yes, now macro and babel are always installed. But frankly speaking, i would not worry too much about non-macro usage, the main use case is with macro and we should concentrate our effort to make it highly polished.

[timofei-iatsenko]

i don't know why, but i don't like what happened here 😬

We indeed need to split macro for different frameworks, but the idea that all babel dependencies would be installed even if you are not using them makes me nervous.

Also i don't understand how we should organize tests in the repo. Now they live in one place, and we have cases where jsx + and js macro tested together. How this should be done after split i don't know.

[andrii-bodnar]

Let's postpone it to the future major release (v5 or v6), maybe later we will have a better understanding of how to properly do this

[andrii-bodnar]

Will close this PR for now