chore: deprecate isTranslated prop #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vonovak
force-pushed
the
chore/deprecate-is-translated
branch
from
04e5966
to
e4f2604
Compare
size-limit report 📦
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1772 +/- ##
=======================================
Coverage 76.26% 76.26%
=======================================
Files 81 81
Lines 2069 2069
Branches 528 528
=======================================
Hits 1578 1578
Misses 379 379
Partials 112 112
☔ View full report in Codecov by Sentry. |
andrii-bodnar
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small maintenance PR: this prop is not really documented and it's buggy, as seen in #1643 (comment)
I tried to print a console warning when user accesses the prop so they get a message. However, React itself reads the props when calling createElement and so even if users don't use the prop, the warning would be logged. We'd need to do some heuristic on the stack trace to determine when to not print the warning and it wouldn't be pretty.
Types of changes
Fixes # (issue)
Checklist