Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: wording in react-patterns.md #1779

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Conversation

vonovak
Copy link
Collaborator

@vonovak vonovak commented Oct 6, 2023

Description

just a follow up on the recent PR which I didn't get to comment in time :D

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 7:28am

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.83 KB (0%)
./packages/detect-locale/dist/index.mjs 721 B (0%)
./packages/react/dist/index.mjs 1.68 KB (0%)
./packages/remote-loader/dist/index.mjs 7.24 KB (0%)

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5cfa605) 76.27% compared to head (9776247) 76.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1779   +/-   ##
=======================================
  Coverage   76.27%   76.27%           
=======================================
  Files          81       81           
  Lines        2074     2074           
  Branches      529      529           
=======================================
  Hits         1582     1582           
  Misses        380      380           
  Partials      112      112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-bodnar andrii-bodnar merged commit 0495209 into lingui:main Oct 6, 2023
17 checks passed
@vonovak vonovak deleted the patch-1 branch October 6, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants