-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): support multiple locales in extract command #1858
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dan-dr thank you!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1858 +/- ##
==========================================
- Coverage 76.66% 76.48% -0.19%
==========================================
Files 81 81
Lines 2083 2088 +5
Branches 532 533 +1
==========================================
Hits 1597 1597
- Misses 375 380 +5
Partials 111 111 ☔ View full report in Codecov by Sentry. |
What needs to happen to merge? :) |
Hi! Strictly speaking, you first want to do the trimming and then the filtering 🙈🙂 |
yikes! 😨 |
done |
not released yet? 😭 |
@dan-dr It has been merged into the Edit: I think Andrii meant v5 🙂 |
got it. why though? could be useful right away |
Description
Adds multiple locales support for
--locale
option, similar to the experimental extract implementation.Types of changes
Checklist