You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only works in client components anyway. Why not add 'use client' here so that it doesn't blow up when composed in server components?
Description
//: # The Trans component as is cannot be used directly in Server Components. If we make a wrapper for it, then it ruins extraction for the instances that use the wrapper. I believe this would solve that issue. It appears that the eventual solution for an RSC version would involve an alternate version of the component that is swapped in via a compile time plugin, so we may as well go with the fact that this specific component will be exlcusive to the client side, and mark it as such ('use client') so that it integrates with RSCs better.
Types of changes
Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
So the thing is, NexJS team doesn't provide library authors with a clear guideline how to incorporate this "use client" in the usual library building pipeline.
The problem is, code of the library transpiled and bundled into one file, so this "use client" will not appear at the top of the module, and will not work as you are expecting.
Yes this a thing... bundler support for "use client" is subpar for now. In the Nextjs docs they talk about it and have some examples of how to do it with esbuild I think.
Well, it seems the "proposed way" is to just turn the whole bundle into "use client". Since we have a separate entrypoint for TransNoContext that may work...
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only works in client components anyway. Why not add 'use client' here so that it doesn't blow up when composed in server components?
Description
//: # The Trans component as is cannot be used directly in Server Components. If we make a wrapper for it, then it ruins extraction for the instances that use the wrapper. I believe this would solve that issue. It appears that the eventual solution for an RSC version would involve an alternate version of the component that is swapped in via a compile time plugin, so we may as well go with the fact that this specific component will be exlcusive to the client side, and mark it as such (
'use client') so that it integrates with RSCs better.Types of changes
Fixes # (issue)
Checklist