Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove the deprecated 'isTranslated' property #1907

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

andrii-bodnar
Copy link
Contributor

Description

The isTranslated prop is undocumented and buggy.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2024 6:44am

Copy link

github-actions bot commented Apr 5, 2024

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.86 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.67 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.15%. Comparing base (1f18e68) to head (17dc3f4).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1907      +/-   ##
==========================================
- Coverage   77.16%   77.15%   -0.02%     
==========================================
  Files          84       84              
  Lines        2159     2158       -1     
  Branches      557      556       -1     
==========================================
- Hits         1666     1665       -1     
  Misses        381      381              
  Partials      112      112              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-bodnar andrii-bodnar merged commit 4c494ad into next Apr 5, 2024
16 checks passed
@andrii-bodnar andrii-bodnar deleted the chore/remove-deprecated-property branch April 5, 2024 12:34
@andrii-bodnar andrii-bodnar added this to the v5 milestone Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants