-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(macro): use message descriptor for Trans #1909
Merged
andrii-bodnar
merged 4 commits into
lingui:next
from
timofei-iatsenko:refactor/trans-message-descriptor
May 21, 2024
Merged
refactor(macro): use message descriptor for Trans #1909
andrii-bodnar
merged 4 commits into
lingui:next
from
timofei-iatsenko:refactor/trans-message-descriptor
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
7 tasks
size-limit report 📦
|
8 tasks
timofei-iatsenko
force-pushed
the
refactor/trans-message-descriptor
branch
from
April 12, 2024 07:34
3bc87c4
to
94d9c78
Compare
3 tasks
Comment on lines
+3
to
+4
describe.skip("", () => {}) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
andrii-bodnar
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the same message descriptor with
/* i18n */
extraction mark in<Trans>
component so extractor will supportTransNoContext
or runtimeConfigModule without explicit knowledge about them.Take the input:
Before
After
Where
Is standard message descriptor used in
t
transformation.A side effect of this change is reduced code duplication between js and jsx macro.
Types of changes
Fixes # (issue)
Checklist