fix: windows compatibility

[timofei-iatsenko]

Description

i installed Windows ARM on my Mac, and fixed all compatibility issues which were marked as "skipOnWindows" in tests.

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Examples update

Fixes # (issue)

Checklist

• I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
• I have added tests that prove my fix is effective or that my feature works
• I have added the necessary documentation (if appropriate)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
js-lingui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 13, 2024 8:36am

[github-actions]

size-limit report 📦

Path	Size
./packages/core/dist/index.mjs	2.88 KB (0%)
./packages/detect-locale/dist/index.mjs	723 B (0%)
./packages/react/dist/index.mjs	1.65 KB (0%)
./packages/remote-loader/dist/index.mjs	7.26 KB (0%)

[codecov]

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.16%. Comparing base (dd43fb0) to head (dd3bc1f).
Report is 74 commits behind head on next.

Files	Patch %	Lines
packages/cli/src/lingui-compile.ts	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #1996      +/-   ##
==========================================
- Coverage   76.66%   76.16%   -0.51%     
==========================================
  Files          81       81              
  Lines        2083     2249     +166     
  Branches      532      588      +56     
==========================================
+ Hits         1597     1713     +116     
- Misses        375      420      +45     
- Partials      111      116       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yunsii]

Does it will fix this issue #1793?

[timofei-iatsenko]

I hope so. I found that path issues on windows become even more weird when inter-disc execution is involved. For example, code working perfectly when it stored on disk C, but then suddenly become broken when you just move it to the disk D.

There is also no way to express a relative path between these two disks, and not every tool understand an absolute windows paths.

[yunsii]

but then suddenly become broken when you just move it to the disk D.

I always think the comment is relative path in git repo, why related the inter-disc execution? 😦

[timofei-iatsenko]

Exactly, it should be relative to the rootDir specified in the lingui config. And that the goal i wanted to achieve, so no matter where files are stored result should be the same. But on windows, it turned out that it might be broken due to where files are stored, which is weird.

The inter disc execution happened in experimental extractor. Previously, it used os.tmpDir() to store esbuild generated bundles. On windows it's always would be on the system disk (C:) and if you code stored on disk D: esbuild not able to generate a correct relative path to sources, and then lingui extractor could not make this path relative to rootDir.

[yunsii]

Is it possible to make lingui extractor always use same disk (maybe C:) to parse relative path?

[timofei-iatsenko]

That exactly what i did in this PR, among other things

[andrii-bodnar]

@thekip thank you!

[bravo-kernel]

This is great, much appreciated 👏