Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve catalog format options description #2050

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

andrii-bodnar
Copy link
Contributor

Description

Added tables instead of raw code blocks. This brings more readability and improves the search.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview Oct 16, 2024 1:11pm

Copy link

github-actions bot commented Oct 16, 2024

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.88 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.68 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

@andrii-bodnar andrii-bodnar merged commit b8b4b19 into main Oct 16, 2024
14 checks passed
@andrii-bodnar andrii-bodnar deleted the docs/catalog-formats branch October 16, 2024 13:17
maastrich added a commit to maastrich/js-lingui that referenced this pull request Oct 18, 2024
…acro

This commit adds error handling for dynamically importing the @lingui/macro module in the vite-plugin. When the @lingui/macro module is dynamically imported, an error is thrown with a helpful message guiding the user to check their import statement and providing a link to the documentation for configuring Vite with Lingui correctly.

Closes lingui#2050
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant