Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(extractor): support decoratorAutoAccessors and improve docs #2058

Merged
merged 1 commit into from
Oct 21, 2024
Merged

feat(extractor): support decoratorAutoAccessors and improve docs #2058

merged 1 commit into from
Oct 21, 2024

Conversation

timofei-iatsenko
Copy link
Collaborator

Description

Fixes #2057 and improve documentation to shed a light on some previously taken decision.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

@vercel Vercel
Copy link

vercel bot commented Oct 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview Oct 20, 2024 9:07am

@timofei-iatsenko timofei-iatsenko changed the base branch from main to next October 20, 2024 09:06
@timofei-iatsenko timofei-iatsenko changed the title Extractor docs @timofei-iatsenko feat(extractor): support decoratorAutoAccessors and improve docs Oct 20, 2024
@timofei-iatsenko timofei-iatsenko changed the title @timofei-iatsenko feat(extractor): support decoratorAutoAccessors and improve docs feat(extractor): support decoratorAutoAccessors and improve docs Oct 20, 2024
@timofei-iatsenko timofei-iatsenko changed the title feat(extractor): support decoratorAutoAccessors and improve docs feat(extractor): support decoratorAutoAccessors and improve docs Oct 20, 2024
@github-actions GitHub Actions
Copy link

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.88 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.68 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

vonovak
vonovak approved these changes Oct 20, 2024
View reviewed changes
Copy link
Collaborator

@vonovak vonovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, this does make this part of Lingui easier to understand 🙏👍

@andrii-bodnar andrii-bodnar merged commit c0e4816 into next Oct 21, 2024
12 of 14 checks passed
@andrii-bodnar andrii-bodnar deleted the extractor-docs branch October 21, 2024 08:02
@timofei-iatsenko timofei-iatsenko mentioned this pull request Oct 21, 2024
Closed
3 tasks
@andrii-bodnar andrii-bodnar added this to the v5 milestone Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrii-bodnar andrii-bodnar andrii-bodnar approved these changes

@vonovak vonovak vonovak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v5
Development

Successfully merging this pull request may close these issues.

lingui extract babel config doesn't support experimental syntax 'decoratorAutoAccessors'
3 participants
@timofei-iatsenko @vonovak @andrii-bodnar