Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(macro): deprecate custom i18n instance on t macro #2059

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

timofei-iatsenko
Copy link
Collaborator

Description

As stated in the migration doc. There few ways to achieve the same result, it's better to stick with the one for consistency. As a benefit we can remove significant layer of complexity from SWC / babel / Eslint integrations.

I've created a GritQL migration and test in the studio only. I don't know how to correctly run this migration in the users codebase, once i figure it out i will update gist or the doc.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented Oct 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview Nov 6, 2024 3:02pm

Copy link

github-actions bot commented Oct 20, 2024

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 3.09 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.65 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

@morgante
Copy link

I've created a GritQL migration and test in the studio only. I don't know how to correctly run this migration in the users codebase, once i figure it out i will update gist or the doc.

If you make a markdown file in this repo .grit/patterns/migrate_t.md then users will just be able to apply it like this:

grit apply github.com/lingui/js-lingui#migrate_t

Thanks for trying Grit!

@andrii-bodnar andrii-bodnar added this to the v5 milestone Oct 23, 2024
@andrii-bodnar andrii-bodnar merged commit 5d82d37 into next Nov 7, 2024
9 of 10 checks passed
@andrii-bodnar andrii-bodnar deleted the deprecate-t-signature branch November 7, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants