Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: runtimeConfigModule config validation #972

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Conversation

arcanis
Copy link
Contributor

@arcanis arcanis commented Feb 8, 2021

It seems like the validation got stricter, and runtimeConfigModule alternative syntax (#895) wasn't covered.

@vercel
Copy link

vercel bot commented Feb 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/pny6deo6x
✅ Preview: https://js-lingui-git-fork-arcanis-patch-3.lingui-js.now.sh

@arcanis arcanis changed the title Fixes validation for runtimeConfigModule fix: config validation Feb 8, 2021
@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #972 (f072b9c) into main (b9683cc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #972   +/-   ##
=======================================
  Coverage   83.30%   83.30%           
=======================================
  Files          53       53           
  Lines        1605     1605           
  Branches      430      430           
=======================================
  Hits         1337     1337           
  Misses        156      156           
  Partials      112      112           
Impacted Files Coverage Δ
packages/conf/src/index.ts 80.51% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9683cc...f072b9c. Read the comment docs.

@arcanis arcanis changed the title fix: config validation fix: config validation Feb 8, 2021
@semoal semoal changed the title fix: config validation fix: runtimeConfigModule config validation Feb 8, 2021
@semoal semoal merged commit 5656c95 into lingui:main Feb 8, 2021
@semoal
Copy link
Contributor

semoal commented Feb 8, 2021

Thanks you so much Maël! Much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants