Add test that we can actually download markdown version and screenshot of GitHub README page in all our supported engines #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: undefined
… downloads - Add comprehensive test suite for GitHub README page in all supported browser engines - Test markdown download and conversion with both Puppeteer and Playwright engines - Test screenshot capture with both Puppeteer and Playwright engines - Add engine parity tests to ensure both engines produce valid results - Fix Playwright browser adapter to properly handle browser context - Update jest.config.mjs to include integration tests in test matching patterns All 11 new tests pass successfully, verifying that both Puppeteer and Playwright can download and convert the GitHub README page to markdown and capture screenshots. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
changed the title
This reverts commit 89811e6.
Collaborator
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 📎 Log file uploaded as GitHub Gist (343KB) Now working session is ended, feel free to review and add any feedback on the solution draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive integration tests to verify that we can download markdown versions and screenshots of the GitHub README page using all supported browser engines (Puppeteer and Playwright).
Changes Made
New Test File:
tests/integration/github-readme.test.jsBrowser Abstraction Layer Fix:
src/browser.jssetUserAgenthandling for Playwright (which doesn't support it the same way as Puppeteer)Jest Configuration Update:
jest.config.mjsTest Coverage
Markdown Download Tests:
Screenshot Download Tests:
Engine Parity Tests:
Test Results
All 11 tests pass successfully:
Fixes
Fixes #5
🤖 Generated with Claude Code