-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support autoredirection #54
Conversation
This allows the user to pass in the arn as a url argument and be immediately redirected to it.
Thank you for the contribution. This is an interesting idea. I apologize in advance that this will take me some time to review. I will need to carefully think about what input validation link2aws is doing and needs to do before we merge this, as this can have security implications (Open Redirect Abuse: link/link). A few more review thoughts:
|
Any further thoughts on this @fxkr? |
Hi @Jeff-SearchPilot , sorry for the delay. I have been traveling and haven't had any time to look at this yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Jeff-SearchPilot , I have now merged a commit with extra input validation, so that we can go ahead with this now. Can you address the following review comments?
Thank you very much!
Thanks! Merged. |
This allows the user to pass in the arn as a url argument and be immediately redirected to it.