-
-
Notifications
You must be signed in to change notification settings - Fork 80
Don't have any scoped CSS #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@linkdotnet I would like to work on this issue. can you assign it to me? |
Love it - thanks and done ;) also don’t feel pressured to do all the work. I am fine if we split this into multiple PRs. |
Hey @otutukingsley I removed the assignment for now. If you work on this, let me know and I add you again |
Hello there, how is going this task? I am interested in providing more support to the project and it seems this one at my reach and for learning into front-end too. |
If you want, feel free to pick it up and ask me any question regarding it. My idea would not only be removing any scoped CSS and move it to the root CSS, but also use more bootstrap utility classes when applicable. I started my journey without much knowledge of bootstrap itself, so I created way too much custom CSS where it wasn't necessary. So probably I would do it in 3 steps:
|
Thanks for the info and steps will write when I get some progress |
I have a stronger opinion, that we should go into the direction of something like tailwindcss that makes a lot of things easier. I tried it out in another Blazor project, and with v4, it was a pleasant experience. |
That sounds good and interesting. I am looking at Tailwindcss because I am also learning some front-end, but I haven't been able to progress that much because of work and other stuff. |
@EliasMasche If you need a basic setup for |
thanks and the same task is required for the branch of tailwind? or something else will be the work |
No no. This was just my "playground" with tailwind 4. You can use it if you wish, but feel free to use your own branch/process/style/... |
Ah gotcha, thanks for the info, so about this task we will still be available or gonna be deprecated with tailwind css? |
The task is still valid:
But that might be too big to tackle anyway - that is why I just played around. Using tailwind would mean to go through every component and somewhat restyle it (I am absolutely fine with that, even if that means the blog looks different, which I welcome). But that is nothing you do in an hour or two :D |
Oki doki, thanks for the info and update, I will take a look through my free time and post some updates |
Hello there. I have time this week to tackle about ScopedCSS first with bootstrap and later for tailwind branch.
Or maybe I am confused with Blazor CSS Isolation |
The idea is to remove all
My hope would be not to have enormous amounts of custom CSS in the first place. |
Thanks for the explanation. I understand better now. A plan I have for removing all Is that sound good I will start working from there |
Basically there shouldn't be any |
I opened a draft of PR for Scoped CSS refactor I had a slow start because of the unhandled exception at my local PC, but at least Codespaces saved me. It was an interesting experience. I classified into smaller CSS files the It is an initial draft, and that can be improved how to organize the files, An issue I am having with I tried changing and naming it uniquely but wasn't able to fix it |
While scoped CSS is nice, it also makes certain things like creating critical CSS more complicated.
Therefore all scoped CSS should either:
The text was updated successfully, but these errors were encountered: