Simplify example code showing setting solidFetcher #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `@inrupt/solid-client-authn-browser` SDK, we always expose a `fetch` method, so you don't need to set `solidFetcher` only after login, you can do this before and it'll switch based on whether you're logged in or not — by default the `fetch` method uses global fetch until the session is established, at which point it switches to fetch with authorization and dpop headers.
|
LGTM, thanks for catching those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
@inrupt/solid-client-authn-browserSDK, we always expose afetchmethod, so you don't need to setsolidFetcheronly after login, you can do this before and it'll switch based on whether you're logged in or not — by default thefetchmethod uses global fetch until the session is established, at which point it switches to fetch with authorization and dpop headers.