Skip to content

Enable recommended default modules for golintci/revive #808

@dpippenger

Description

@dpippenger

Golintci now contains an updated version of revive that has an updated default rule list that aligns with their recommended configuration. See mgechev/revive#799 for details.

Two of the newly recommended rules fail on the current code tree with what seem to be legitimate complaints. I disabled these rules to get the CI unblocked on go 1.21.x for this issue #806. It would probably be worthwhile to re-enable these rules and update the code to pass.

https://github.com/linkedin/Burrow/blob/master/.golangci.yml#L48
https://github.com/linkedin/Burrow/blob/master/.golangci.yml#L61

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions