Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: expose consumer group lag as prometheus metrics #149

Closed
wants to merge 11 commits into from
Closed

wip: expose consumer group lag as prometheus metrics #149

wants to merge 11 commits into from

Conversation

JamieAP
Copy link

@JamieAP JamieAP commented Nov 1, 2016

No description provided.

@baakind
Copy link

baakind commented Dec 7, 2017

Is there a reason why this PR died? We are currently using Burrow to monitor lag and partition-status, and we do want to monitor this using Prometheus. I can see that it is a bit outdated, but I'm curious if there is a reason why it just died. @toddpalino @JamieAP

@toddpalino
Copy link
Contributor

Not sure why this dropped out, but it probably needs a do-over for 1.0 anyways. The one caveat I would say on that is that if the write to prometheus is straight HTTP, it should probably be implemented using the HTTP notifier and an example template and config provided (which can be added to the documentation).

We do something like this internally with metrics, but I haven't published a sample template yet.

@varun06
Copy link

varun06 commented Dec 12, 2017

Yeah, I am also looking for prom metrics in burrow.

@daodennis-zz
Copy link
Contributor

There is some existing work too that maybe we can borrow for Burrow in the burrow_exporter

Other projects like Kubernetes, etcd, and Docker utilize Prometheus instrumentation. Also, organizations like Cloudflare who use both Kafka and Prometheus like ours are not an isolated intersection. There is a formidable and active operator community behind Prometheus as well.
Anyway...

jirwin's exporter has these metrics:

KafkaConsumerPartitionCurrentOffset
KafkaConsumerPartitionMaxOffset
KafkaConsumerTotalLag

Also, it would be nice to expose operational metrics, most places where there's a logging statement could use a metric. @JamieAP are you planning on shoring this PR up for 1.0 by chance?

@varun06
Copy link

varun06 commented Dec 27, 2017

Don't want to ruin holiday week, but if any help needed for this PR, I can find some time. Will really appreciate if this get merged sooner than later.

@JamieAP
Copy link
Author

JamieAP commented Jan 2, 2018

Sorry for the delay. I abandoned this (and forgot to tidy the PR) in favour of building something slightly more specific to my use case. I'm unlikely to have any time to work on this PR in the next couple of weeks so please feel free to pick it up.

@toddpalino Prometheus uses a pull model. The prometheus backend makes a request to an endpoint to fetch metrics rather than a service making a request to a prometheus endpoint to write them. The HTTP notifier would be no help here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants