Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional filter to subscription reconciler #65

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

ryannedolan
Copy link
Collaborator

@ryannedolan ryannedolan commented Jun 21, 2024

Summary

Added optional filter predicate to subscription reconciler.

Details

One way to serve multiple use-cases is to run Hoptimator in multiple namespaces, each with different configurations. However, this proves unwieldy in practice, because each namespace has its own operational overhead (e.g. RBAC policies). Instead, it is convenient to have Hoptimator partition a single namespace based on its own criteria (e.g. subscription prefix).

To that end, we add support for filtering Subscriptions. This enables an operator to spin up multiple Subscription controllers, each with different filters and different configurations -- all in the same namespace. For example, an operator may want to treat Subscriptions differently if they have a -staging or -prod suffix.

Testing

Tested in downstream project.

@ryannedolan ryannedolan force-pushed the subscription-filter branch from fea7ed5 to 422edb2 Compare June 21, 2024 13:50
@ryannedolan ryannedolan force-pushed the subscription-filter branch from 422edb2 to d175b79 Compare June 21, 2024 15:27
@ryannedolan ryannedolan enabled auto-merge (squash) July 8, 2024 16:50
@ryannedolan ryannedolan requested review from ehoner and hshukla July 8, 2024 22:37
@ryannedolan ryannedolan merged commit 9a9a9eb into main Jul 10, 2024
1 check passed
@ryannedolan ryannedolan deleted the subscription-filter branch July 10, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants