Fix default watch namespacing #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryannedolan
requested changes
Jan 29, 2025
There was a problem hiding this comment.
I don't think making the "namespace" configurable makes sense. There are only two possible situations: the operator is running inside K8s (in which case it will know what namespace to use), or it is running outside. If outside, we already have kube/config, which lets you configure any namespace. I don't think overriding that logic makes sense.
That said, adding a watch argument makes sense. Operators typically do that. I think we should just thread that through to registerInformer rather than muck with K8sContext, since that is meant to be a read-only singleton.
hoptimator-k8s/src/main/java/com/linkedin/hoptimator/k8s/K8sContext.java
Outdated
Show resolved
Hide resolved
hoptimator-k8s/src/main/java/com/linkedin/hoptimator/k8s/K8sContext.java
Outdated
Show resolved
Hide resolved
hoptimator-k8s/src/main/java/com/linkedin/hoptimator/k8s/K8sContext.java
Show resolved
Hide resolved
hoptimator-operator/src/main/java/com/linkedin/hoptimator/operator/HoptimatorOperatorApp.java
Outdated
Show resolved
Hide resolved
hoptimator-operator/src/main/java/com/linkedin/hoptimator/operator/HoptimatorOperatorApp.java
Show resolved
Hide resolved
hoptimator-operator/src/main/java/com/linkedin/hoptimator/operator/PipelineOperatorApp.java
Outdated
Show resolved
Hide resolved
jogrogan
force-pushed
the
jogrogan/namespace
branch
from
5064122 to
f54aee4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OperatorandK8sContext, split usages of namespaces to watch vs expected default namespace to operate within.