Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Qwen2 VL test for with logits conv test #463

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Disable Qwen2 VL test for with logits conv test #463

merged 1 commit into from
Dec 10, 2024

Conversation

ByronHsu
Copy link
Collaborator

Summary

Testing Done

  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@ByronHsu ByronHsu mentioned this pull request Dec 10, 2024
Closed
@ByronHsu ByronHsu changed the title Disable Qwen2 VL test for with logits conv test too Disable Qwen2 VL test for with logits conv test Dec 10, 2024
@ByronHsu ByronHsu merged commit c33583a into main Dec 10, 2024
5 checks passed
@ByronHsu ByronHsu deleted the byhsu/disable-qwen2-vl-for-logits branch December 10, 2024 09:55
This was referenced Dec 10, 2024
Merged
Merged
ByronHsu pushed a commit that referenced this pull request Dec 11, 2024
@austin362667
Revert Workaround of Disabling QWEN2_VL in Convergence Tests (#466)
96859d8 
## Summary

After fix #464

We can revert some changes in

- #463
- #459

Which are workarounds of

#461

<!---
## Details
This is an optional section; is there anything specific that reviewers
should be aware of?
--->

## Testing Done
<!--- This is a required section; please describe how this change was
tested. --->

<!-- 
Replace BLANK with your device type. For example, A100-80G-PCIe

Complete the following tasks before sending your PR, and replace `[ ]`
with
`[x]` to indicate you have done them. 
-->

- Hardware Type: <BLANK>
- [ ] run `make test` to ensure correctness
- [X] run `make checkstyle` to ensure code style
- [X] run `make test-convergence` to ensure convergence

---------

Signed-off-by: Austin Liu <austin362667@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ByronHsu