Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix chosen_nll_loss in chunked loses #486

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix chosen_nll_loss in chunked loses #486

wants to merge 5 commits into from
+74 −27

Conversation

kashif
Copy link
Contributor

@kashif kashif commented Dec 17, 2024 •
edited
Loading

Summary

Fix the nll loss in the the chunked loses when the model is a decoder only model, by shifting the logits and targets

  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@kashif kashif mentioned this pull request Dec 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kashif