-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combined cloud blob crypto service #1154
Combined cloud blob crypto service #1154
Conversation
Enhance KeyManagementService to take single context string as input.
…encryptionOrigin Add encryption metrics
Codecov Report
@@ Coverage Diff @@
## master #1154 +/- ##
============================================
+ Coverage 69.59% 69.68% +0.09%
- Complexity 5244 5261 +17
============================================
Files 414 416 +2
Lines 32299 32438 +139
Branches 4113 4122 +9
============================================
+ Hits 22478 22604 +126
- Misses 8693 8709 +16
+ Partials 1128 1125 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments on prod. Will look at test soon.
ambry-cloud/src/main/java/com.github.ambry.cloud/CloudBlobStore.java
Outdated
Show resolved
Hide resolved
ambry-cloud/src/main/java/com.github.ambry.cloud/CloudBlobStore.java
Outdated
Show resolved
Hide resolved
ambry-api/src/main/java/com.github.ambry/config/CloudConfig.java
Outdated
Show resolved
Hide resolved
ambry-cloud/src/main/java/com.github.ambry.cloud/azure/AzureCloudDestination.java
Show resolved
Hide resolved
ambry-cloud/src/main/java/com.github.ambry.cloud/CloudBlobStore.java
Outdated
Show resolved
Hide resolved
ambry-cloud/src/main/java/com.github.ambry.cloud/CloudBlobCryptoAgentImpl.java
Outdated
Show resolved
Hide resolved
ambry-cloud/src/main/java/com.github.ambry.cloud/CloudBlobCryptoAgentFactoryImpl.java
Outdated
Show resolved
Hide resolved
ambry-cloud/src/main/java/com.github.ambry.cloud/CloudBlobCryptoAgentImpl.java
Show resolved
Hide resolved
ambry-cloud/src/main/java/com.github.ambry.cloud/CloudBlobCryptoAgentImpl.java
Outdated
Show resolved
Hide resolved
ambry-cloud/src/main/java/com.github.ambry.cloud/CloudBlobCryptoAgentImpl.java
Show resolved
Hide resolved
ambry-cloud/src/main/java/com.github.ambry.cloud/VcrServer.java
Outdated
Show resolved
Hide resolved
ambry-cloud/src/main/java/com.github.ambry.cloud/VcrServer.java
Outdated
Show resolved
Hide resolved
ambry-cloud/src/main/java/com.github.ambry.cloud/CloudBlobMetadata.java
Outdated
Show resolved
Hide resolved
ambry-cloud/src/test/java/com.github.ambry.cloud/azure/AzureIntegrationTest.java
Outdated
Show resolved
Hide resolved
ambry-cloud/src/test/java/com.github.ambry.cloud/azure/AzureIntegrationTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Combined changes from @dharju and @lightningrob.