Make CompositeClusterManager more robust to NPEs and other errors #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Handle equality checks correctly for methods that can return null. - Catch checked exceptions that HelixClusterManager may throw. This ensures that StaticClusterManager acts as the source of truth and failures in HelixClusterManager will not affect CompositeClusterManager's operation.
jsjtzyy
reviewed
May 1, 2019
| @@ -31,6 +34,7 @@ | |||
| * and reports inconsistencies in the views from the two underlying cluster managers. | |||
| */ | |||
| class CompositeClusterManager implements ClusterMap { | |||
| private static final Logger LOGGER = LoggerFactory.getLogger(CompositeClusterManager.class); | |||
| final StaticClusterManager staticClusterManager; | |||
| final HelixClusterManager helixClusterManager; | |||
| final HelixClusterManagerMetrics helixClusterManagerMetrics; | |||
There was a problem hiding this comment.
Let's add strict check for both helixClusterManager and helixClusterManagerMetrics. That is, check if they are null in all places where dereference is invoked.
There was a problem hiding this comment.
After fixing the constructor, all places where these are used are surrounded by a null check.
jsjtzyy
reviewed
May 1, 2019
Codecov Report
@@ Coverage Diff @@
## master #1164 +/- ##
============================================
- Coverage 69.79% 69.71% -0.08%
+ Complexity 5328 5326 -2
============================================
Files 425 425
Lines 32644 32652 +8
Branches 4147 4148 +1
============================================
- Hits 22784 22764 -20
- Misses 8723 8747 +24
- Partials 1137 1141 +4
Continue to review full report at Codecov.
|
pnarayanan
approved these changes
May 1, 2019
jsjtzyy
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensures that StaticClusterManager acts as the source of truth and
failures in HelixClusterManager will not affect
CompositeClusterManager's operation.