Upgrade Helix library version and add auto maintenance mode in HelixVcrPopulateTool #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1194 +/- ##
=========================================
Coverage 83.62% 83.62%
Complexity 57 57
=========================================
Files 6 6
Lines 348 348
Branches 38 38
=========================================
Hits 291 291
Misses 45 45
Partials 12 12Continue to review full report at Codecov.
|
jsjtzyy
approved these changes
Jul 9, 2019
| @@ -141,6 +141,8 @@ static void createCluster(String destZkString, String destClusterName) { | |||
| ConfigAccessor configAccessor = new ConfigAccessor(destZkClient); | |||
| ClusterConfig clusterConfig = configAccessor.getClusterConfig(destClusterName); | |||
| clusterConfig.setPersistBestPossibleAssignment(true); | |||
| clusterConfig.setMaxOfflineInstancesAllowed(4); // if offline instances >= 4, helix enters maintenance mode. | |||
There was a problem hiding this comment.
can you move comments to a separate line?
| @@ -141,6 +141,8 @@ static void createCluster(String destZkString, String destClusterName) { | |||
| ConfigAccessor configAccessor = new ConfigAccessor(destZkClient); | |||
| ClusterConfig clusterConfig = configAccessor.getClusterConfig(destClusterName); | |||
| clusterConfig.setPersistBestPossibleAssignment(true); | |||
| clusterConfig.setMaxOfflineInstancesAllowed(4); // if offline instances >= 4, helix enters maintenance mode. | |||
There was a problem hiding this comment.
Better to make thresholds (enter/exit maintenance mode) configurable.
lightningrob
requested changes
Jul 12, 2019
| clusterConfig.setPersistBestPossibleAssignment(true); | ||
| clusterConfig.setMaxOfflineInstancesAllowed(4); |
There was a problem hiding this comment.
Could we make the min/max values configurable? the defaults seem okay but would be good to add optional command line args to override them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Helix library version.
Add auto maintenance mode in HelixVcrPopulateTool.