Run azure recovery locally #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzmao
reviewed
Aug 5, 2019
ankagrawal
commented
Aug 5, 2019
ambry-cloud/src/main/java/com.github.ambry.cloud/azure/CosmosDataAccessor.java
Outdated
Show resolved
Hide resolved
lightningrob
reviewed
Aug 6, 2019
lightningrob
requested changes
Aug 6, 2019
ankagrawal
force-pushed
the
run_local_azure_recovery
branch
from
5f69144 to
1d2f137
Compare
| @@ -0,0 +1,61 @@ | |||
| /** | |||
| * Copyright 2016 LinkedIn Corp. All rights reserved. | |||
config/azureconfig/vcr.properties
Outdated
| @@ -0,0 +1,26 @@ | |||
| # | |||
| # Copyright (C) 2014-2016 LinkedIn Corp. All rights reserved. | |||
config/azureconfig/server.properties
Outdated
| @@ -0,0 +1,19 @@ | |||
| # | |||
| # Copyright (C) 2014-2016 LinkedIn Corp. All rights reserved. | |||
There was a problem hiding this comment.
2019 (I don't know why we even need the copyright for property files but as long as we do let's put the current year.)
lightningrob
approved these changes
Aug 15, 2019
cgtz
approved these changes
Aug 15, 2019
config/azureconfig/vcr.properties
Outdated
| clustermap.datacenter.name=Datacenter | ||
| clustermap.host.name=localhost | ||
| clustermap.port=6673 | ||
| azure.storage.connection.string=<CONNECTION STRIGNG FOR AZURE BLOB STORAGE> |
1. Implement vcrmain 2. Add new configs for azure 3. Hack for partitionid (TODO)
ankagrawal
force-pushed
the
run_local_azure_recovery
branch
from
d9d434d to
e271ec5
Compare
Codecov Report
@@ Coverage Diff @@
## master #1230 +/- ##
=========================================
Coverage 88.92% 88.92%
Complexity 60 60
=========================================
Files 6 6
Lines 352 352
Branches 37 37
=========================================
Hits 313 313
Misses 29 29
Partials 10 10Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables vcr on azure to be run locally for the open source code.