Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable shipkit release publishing #1239

Merged
merged 7 commits into from
Aug 22, 2019
Merged

Conversation

cgtz
Copy link
Contributor

@cgtz cgtz commented Aug 16, 2019

Tested locally using ./gradlew testRelease
I have set up travis-ci environment variables to use my bintray/github account/api keys.

@cgtz cgtz requested a review from ankagrawal August 16, 2019 00:59
@codecov-io
Copy link

codecov-io commented Aug 16, 2019

Codecov Report

Merging #1239 into master will decrease coverage by 13.62%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #1239       +/-   ##
=============================================
- Coverage     85.84%   72.22%   -13.63%     
- Complexity       76     6043     +5967     
=============================================
  Files             9      439      +430     
  Lines           544    34913    +34369     
  Branches         56     4430     +4374     
=============================================
+ Hits            467    25216    +24749     
- Misses           58     8551     +8493     
- Partials         19     1146     +1127
Impacted Files Coverage Δ Complexity Δ
...ava/com.github.ambry/config/PerformanceConfig.java 100% <0%> (ø) 4% <0%> (?)
...main/java/com.github.ambry.cloud/CloudReplica.java 73.91% <0%> (ø) 8% <0%> (?)
...m.github.ambry.replication/ReplicationMetrics.java 94.92% <0%> (ø) 43% <0%> (?)
...ava/com.github.ambry/frontend/SecurityService.java 100% <0%> (ø) 4% <0%> (?)
...b.ambry.cloud/CloudBlobCryptoAgentFactoryImpl.java 81.81% <0%> (ø) 2% <0%> (?)
...ain/java/com.github.ambry/frontend/Operations.java 0% <0%> (ø) 0% <0%> (?)
...n/java/com.github.ambry.clustermap/Datacenter.java 88.7% <0%> (ø) 26% <0%> (?)
...github.ambry.messageformat/TtlUpdateSubRecord.java 100% <0%> (ø) 2% <0%> (?)
...in/java/com.github.ambry.cloud/CloudFindToken.java 33.33% <0%> (ø) 7% <0%> (?)
...i/src/main/java/com.github.ambry/network/Port.java 57.14% <0%> (ø) 5% <0%> (?)
... and 420 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbaf997...2d7899f. Read the comment docs.

cgtz added 4 commits August 16, 2019 11:56
Set up the shipkit gradle plugin for publishing releases to bintray.
Once setup with travis, this should handle automatic generation of
github releases and maven artifacts when PRs are merged to the master
branch.
Copy link
Contributor

@lightningrob lightningrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be great to link the published javadoc to the main README.ml page

.travis.yml Show resolved Hide resolved
build.gradle Show resolved Hide resolved
@cgtz cgtz changed the title WIP: Enable shipkit release publishing Enable shipkit release publishing Aug 16, 2019
@mockitoguy
Copy link
Contributor

This looks good. Thank you!

@lightningrob lightningrob merged commit ba918f5 into linkedin:master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants