Add additional log to track unsatisfied requests #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print out more info of unsatisfied requests for investigation.
jsjtzyy
requested review from
cgtz
and removed request for
justinlin-linkedin
Codecov Report
@@ Coverage Diff @@
## master #1372 +/- ##
===========================================
+ Coverage 71.98% 72% +0.02%
- Complexity 6756 6758 +2
===========================================
Files 486 486
Lines 38353 38371 +18
Branches 4879 4883 +4
===========================================
+ Hits 27609 27630 +21
+ Misses 9410 9408 -2
+ Partials 1334 1333 -1
Continue to review full report at Codecov.
|
cgtz
approved these changes
Feb 7, 2020
| */ | ||
| private void logUnsatisfiedRequest(Map<PerformanceIndex, Long> requestPerfToCheck) { | ||
| StringBuilder sb = new StringBuilder(); | ||
| sb.append("Unsatisfied request: ").append(request.getUri()).append(" method=").append(request.getRestMethod()); |
There was a problem hiding this comment.
"; method=" and say uri=request.getUri() to match the other key value pairs
| sb.append("; blob size=").append((String) blobSize); | ||
| } | ||
| for (Map.Entry<PerformanceIndex, Long> entry : requestPerfToCheck.entrySet()) { | ||
| sb.append("; ").append(entry.getKey().toString()).append(": ").append(entry.getValue()); |
There was a problem hiding this comment.
change ": " to "=" to match other key value pairs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print out more info of unsatisfied requests for investigation.