-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add handleUndeleteRequest method to AmbryRequests #1379
Add handleUndeleteRequest method to AmbryRequests #1379
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1379 +/- ##
===========================================
+ Coverage 72.34% 72.45% +0.1%
- Complexity 6870 6881 +11
===========================================
Files 496 496
Lines 38854 38933 +79
Branches 4940 4947 +7
===========================================
+ Hits 28109 28207 +98
+ Misses 9386 9368 -18
+ Partials 1359 1358 -1
Continue to review full report at Codecov.
|
15c4975
to
3151965
Compare
ambry-protocol/src/main/java/com.github.ambry.protocol/AmbryRequests.java
Outdated
Show resolved
Hide resolved
ambry-protocol/src/main/java/com.github.ambry.protocol/AmbryRequests.java
Outdated
Show resolved
Hide resolved
ambry-protocol/src/main/java/com.github.ambry.protocol/AmbryRequests.java
Outdated
Show resolved
Hide resolved
ambry-protocol/src/main/java/com.github.ambry.protocol/AmbryRequests.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments left.
0160586
to
bec9a78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one minor comment left
Adding handleUndeleteRequest method to AmbryRequests class to handle undelete requests from ambry-frontend.
Add unit test and integration test for handleUndeleteRequest
Change some of the Store implementation in replication test, but since we are not change replication logic for undelete now, we don't change those implementation to support undelete for now.