Add new version of DeleteRequest format #2814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 26, 2024 13:57
…ombstone forcefully
| BlobId id = new BlobId(stream, map); | ||
| long deletionTimeInMs = stream.readLong(); | ||
| boolean isForceDelete = stream.readByte() == 1; | ||
| return new DeleteRequest(correlationId, clientId, id, deletionTimeInMs, isForceDelete); |
There was a problem hiding this comment.
Should add VERSION_3 here. This constructor would use version 2
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2814 +/- ##
============================================
+ Coverage 64.24% 70.16% +5.91%
- Complexity 10398 11735 +1337
============================================
Files 840 842 +2
Lines 71755 72338 +583
Branches 8611 8705 +94
============================================
+ Hits 46099 50754 +4655
+ Misses 23004 18907 -4097
- Partials 2652 2677 +25 ☔ View full report in Codecov by Sentry. |
justinlin-linkedin
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version contains flag to indicate if we need to insert a delete tombstone even if blob is missing on servers