Reconstruct blobId by excluding partition Id #2910
Conversation
SophieGuo410
force-pushed
the
Branch_construct_caspian_blob_name
branch
from
68bba66 to
3c54211
Compare
SophieGuo410
force-pushed
the
Branch_construct_caspian_blob_name
branch
from
3c54211 to
e057d66
Compare
SophieGuo410
requested review from
Arun-LinkedIn,
justinlin-linkedin and
alyssaxu333
| @@ -845,8 +845,8 @@ public RouterConfig(VerifiableProperties verifiableProperties) { | |||
| verifiableProperties.getDoubleInRange(ROUTER_LATENCY_TOLERANCE_QUANTILE, DEFAULT_LATENCY_TOLERANCE_QUANTILE, | |||
| 0.0, 1.0); | |||
| routerBlobidCurrentVersion = | |||
| verifiableProperties.getShortFromAllowedValues(ROUTER_BLOBID_CURRENT_VERSION, (short) 6, | |||
| new Short[]{1, 2, 3, 4, 5, 6}); | |||
| verifiableProperties.getShortFromAllowedValues(ROUTER_BLOBID_CURRENT_VERSION, (short) 7, | |||
There was a problem hiding this comment.
Like we were discussing offline, even though our CFG2 has version as 6, I am wondering if it may not be safe to change default value to 7 until these changes are rolled out!
| BlobProperties blobProperties = blobInfo.getBlobProperties(); | ||
| boolean isSimpleBlob = !options.isChunkUpload() && !options.skipCompositeChunk(); | ||
| //Chunk upload does not need the customized blobId | ||
| BlobId.BlobDataType blobDataType = isSimpleBlob ? BlobId.BlobDataType.SIMPLE : BlobId.BlobDataType.METADATA; |
There was a problem hiding this comment.
Hmm.. I think we won't know if it is a "simple blob" or "composite blob" until we read data from Netty. Once we cross 4 MB, it becomes composite blob https://github.com/linkedin/ambry/blob/master/ambry-router/src/main/java/com/github/ambry/router/PutOperation.java#L688. I am wondering if we need to exclude this field as well during Ambry ID -> Caspian ID mapping
There was a problem hiding this comment.
I think we can just set all the data type to simple cause we don't need this info for caspian upload.
SophieGuo410
force-pushed
the
Branch_construct_caspian_blob_name
branch
2 times, most recently
from
75c5373 to
2adc236
Compare
SophieGuo410
force-pushed
the
Branch_construct_caspian_blob_name
branch
from
2adc236 to
9d484d1
Compare
No description provided.