Support rename dataset version #2935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SophieGuo410
force-pushed
the
Branch_rename
branch
3 times, most recently
from
2f0bfe9
to
f2f89ce
Compare
SophieGuo410
changed the title
SophieGuo410
changed the title
SophieGuo410
force-pushed
the
Branch_rename
branch
2 times, most recently
from
26e0346
to
7f4fce5
Compare
SophieGuo410
changed the title
ambry-api/src/main/java/com/github/ambry/account/DatasetVersionRecord.java
Show resolved
Hide resolved
ambry-account/src/main/java/com/github/ambry/account/mysql/DatasetDao.java
Outdated
Show resolved
Hide resolved
ambry-account/src/main/java/com/github/ambry/account/mysql/DatasetDao.java
Show resolved
Hide resolved
ambry-account/src/main/java/com/github/ambry/account/mysql/DatasetDao.java
Outdated
Show resolved
Hide resolved
added 7 commits
November 18, 2024 14:18
SophieGuo410
force-pushed
the
Branch_rename
branch
from
38979b2
to
e5e32ee
Compare
ambry-frontend/src/main/java/com/github/ambry/frontend/GetBlobHandler.java
Outdated
Show resolved
Hide resolved
ambry-frontend/src/main/java/com/github/ambry/frontend/GetBlobHandler.java
Outdated
Show resolved
Hide resolved
ambry-frontend/src/main/java/com/github/ambry/frontend/DeleteBlobHandler.java
Outdated
Show resolved
Hide resolved
ambry-frontend/src/main/java/com/github/ambry/frontend/DeleteDatasetHandler.java
Outdated
Show resolved
Hide resolved
ambry-api/src/main/java/com/github/ambry/frontend/DatasetVersionPath.java
Outdated
Show resolved
Hide resolved
added 2 commits
November 19, 2024 10:27
SophieGuo410
force-pushed
the
Branch_rename
branch
from
defa0a9
to
e676407
Compare
justinlin-linkedin
approved these changes
Nov 20, 2024
Comment on lines
355
to
359
| if (datasetVersionRecord.getRenameFrom() != null) { | ||
| return datasetVersionRecord.getRenamedPath(accountName, containerName); | ||
| } else { | ||
| return datasetVersionRecord.getOriginalPath(accountName, containerName); | ||
| } |
There was a problem hiding this comment.
This can be put in one method in DatasetVersionRecord. Let's add this to dataset version recoard
public String getNamedBlobNamePath(String acountName, String containerName) {
if (this.renamedPath != null) {
return getRenamedPath(accountName, containerName);
} else {
return getOriginalPath(accountName, containerName);
}
}
In this way, the reconstructRequestPath doesn't need this branches again.
There was a problem hiding this comment.
Sure, updated.
aga9900
pushed a commit
that referenced
this pull request
Nov 21, 2024
* Support rename dataset version in AccountService * Update to use the colum map to original value * Adding more test and details * Adding handler logic * Address comments * Empty commit to try and rerun unit test * Empty commit to try and rerun unit test * Address comments * Code refactoring * Fix bug for delete * address comments * code refactor * Addressed comments --------- Co-authored-by: Sophie Guo <sopguo@sopguo-mn2.linkedin.biz>
aga9900
pushed a commit
that referenced
this pull request
Nov 21, 2024
* Support rename dataset version in AccountService * Update to use the colum map to original value * Adding more test and details * Adding handler logic * Address comments * Empty commit to try and rerun unit test * Empty commit to try and rerun unit test * Address comments * Code refactoring * Fix bug for delete * address comments * code refactor * Addressed comments --------- Co-authored-by: Sophie Guo <sopguo@sopguo-mn2.linkedin.biz>
aga9900
added a commit
that referenced
this pull request
Nov 22, 2024
* More Changes For LLD * [S3 API] Support for S3 AbortMultipartUpload API (#2940) * Support AbortMultipartUpload for S3 API --------- Co-authored-by: Shan Xu <shaxu@linkedin.com> * Support rename dataset version (#2935) * Support rename dataset version in AccountService * Update to use the colum map to original value * Adding more test and details * Adding handler logic * Address comments * Empty commit to try and rerun unit test * Empty commit to try and rerun unit test * Address comments * Code refactoring * Fix bug for delete * address comments * code refactor * Addressed comments --------- Co-authored-by: Sophie Guo <sopguo@sopguo-mn2.linkedin.biz> * add local store to logs (#2947) Co-authored-by: Navneet Sachan <nsachan@nsachan-mn1.linkedin.biz> * Updating LLD Flow For bootstrap * Updating FileStore Class * updating commit --------- Co-authored-by: Shan Xu <alyssaxu333@gmail.com> Co-authored-by: Shan Xu <shaxu@linkedin.com> Co-authored-by: sopguo <sopguo@linkedin.com> Co-authored-by: Sophie Guo <sopguo@sopguo-mn2.linkedin.biz> Co-authored-by: Navneet Sachan <nsachan@linkedin.com> Co-authored-by: Navneet Sachan <nsachan@nsachan-mn1.linkedin.biz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.