Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slack notification #629

Merged
merged 2 commits into from
Apr 2, 2019
Merged

Conversation

ananthdurai
Copy link
Contributor

@ananthdurai ananthdurai commented Apr 1, 2019

-- Addresses the issue: #625.

Desc:
The self-healing and anomaly detected is the crown feature of Cruise Control, but often the actions taken by Cruise Control provide less visibility to its operation. Adding a slack notification for all the anomaly detection and self-healing will increase Cruise control visibility.

Changelog:
The SlackSelfHealingNotifier extends SelfHealingNotifier and merely override the alerts method to send the notification to Slack.

Configuration:
The following property requires to be configured on cruisecontrol.properties

  1. slack.self.healing.notifier.webhook (Required)
    (Slack webhook URL) Ref:https://api.slack.com/incoming-webhooks
  2. slack.self.healing.notifier.channel (Required)
    (Slack channel name to send the alert, (e.g) #alerts-cruise-control
  3. slack.self.healing.notifier.user (Optional)
    User name to display in the slack notification message. (default: Cruise Control)
  4. slack.self.healing.notifier.icon (Optional)
    Icon to display in the slack notification message. (default: ℹ️ )

To enable Slack notification, set
anomaly.notifier.class=com.linkedin.kafka.cruisecontrol.detector.notifier.SlackSelfHealingNotifier

Copy link
Collaborator

@efeg efeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch -- LGTM!

@efeg
Copy link
Collaborator

efeg commented Apr 2, 2019

@efeg efeg merged commit 231920c into linkedin:master Apr 2, 2019
efeg pushed a commit to efeg/cruise-control that referenced this pull request Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants