Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add restli delete method to soft delete aspect #133

Merged
merged 1 commit into from
Nov 9, 2021
Merged

feat: add restli delete method to soft delete aspect #133

merged 1 commit into from
Nov 9, 2021

Conversation

jywadhwani
Copy link
Contributor

@jywadhwani jywadhwani commented Oct 21, 2021 •
edited
Loading

This change adds a Restli delete method to support soft deletion of an aspect. More details on the delete method can be found here https://linkedin.github.io/rest.li/user_guide/restli_server#delete

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@jywadhwani jywadhwani mentioned this pull request Nov 2, 2021
Merged
4 tasks
@jywadhwani jywadhwani requested a review from jsdonn November 8, 2021 22:24
jsdonn
jsdonn approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@jsdonn jsdonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not 100% related to your change but the other methods are missing javadocs, maybe add them or open an issue for that?

@jywadhwani
Copy link
Contributor Author

LGTM. Not 100% related to your change but the other methods are missing javadocs, maybe add them or open an issue for that?

Thanks for the suggestion, created an issue with this request
#137

@jywadhwani jywadhwani merged commit 5eaf122 into linkedin:master Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsdonn jsdonn jsdonn approved these changes

@keremsahin1 keremsahin1 Awaiting requested review from keremsahin1

@nagarjunakanamarlapudi nagarjunakanamarlapudi Awaiting requested review from nagarjunakanamarlapudi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jywadhwani @jsdonn