feat: Support deletion in EbeanGenericLocalDAO and BaseEntityAgnosticAspectResource #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #454 +/- ##
============================================
+ Coverage 67.52% 67.69% +0.16%
- Complexity 1581 1606 +25
============================================
Files 142 143 +1
Lines 6159 6200 +41
Branches 667 675 +8
============================================
+ Hits 4159 4197 +38
- Misses 1717 1719 +2
- Partials 283 284 +1 ☔ View full report in Codecov by Sentry. |
JiaoMaWHU
changed the title
zhixuanjia
reviewed
Oct 23, 2024
Comment on lines
106
to
109
| if (shouldSkipMAEUpdate(newValue)) { | ||
| return null; | ||
| } | ||
| _producer.produceAspectSpecificMetadataAuditEvent(urn, null, newValue, auditStamp, trackingContext, ingestionMode); |
There was a problem hiding this comment.
how about
if (!shouldSkipMAEUpdate(newValue)) {
_producer.produceAspectSpecificMetadataAuditEvent(urn, null, newValue, auditStamp, trackingContext, ingestionMode);
}
zhixuanjia
reviewed
Oct 23, 2024
Comment on lines
129
to
132
| if (shouldSkipMAEUpdate(newValue)) { | ||
| return null; | ||
| } | ||
| _producer.produceAspectSpecificMetadataAuditEvent(urn, currentValue, newValue, auditStamp, trackingContext, ingestionMode); |
There was a problem hiding this comment.
?
if (!shouldSkipMAEUpdate(newValue)) {
_producer.produceAspectSpecificMetadataAuditEvent(urn, currentValue, newValue, auditStamp, trackingContext, ingestionMode);
}
zhixuanjia
reviewed
Oct 23, 2024
| @@ -128,7 +152,7 @@ public Optional<GenericLocalDAO.MetadataWithExtraInfo> queryLatest(@Nonnull Urn | |||
| final PrimaryKey key = new PrimaryKey(urn.toString(), aspectName, LATEST_VERSION); | |||
| EbeanMetadataAspect metadata = _server.find(EbeanMetadataAspect.class, key); | |||
|
|
|||
| if (metadata == null || metadata.getMetadata() == null) { | |||
| if (metadata == null || metadata.getMetadata() == null || DELETED_VALUE.equals(metadata.getMetadata())) { | |||
There was a problem hiding this comment.
so just to confirm the metadata will be set to DELETED_VALUE in mysql db?
There was a problem hiding this comment.
yes, please see
zhixuanjia
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support deletion in
EbeanGenericLocalDAOandBaseEntityAgnosticAspectResourceWe need to have generic deletion support for annotation metadata.
Long-term wise, team decided to have deletion support in every grpc endpoint.
However, to meet the timeline of the annotation use case, a
deletemethod will be added in theBaseEntityAgnosticAspectResourceso thatannotationGmsresource can expose this action.Details
deletemethod and not send MAE for updatesqueryLatestandbackfillmethods to accommodate deleted dataTesting Done
Checklist