guessPath not to depend on the first level of app directory #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One of Google employees sent out this patch for the fork in AOSP so I sent out this for review as well. Note the author also updated existing cases to match the most recently released Android version, and added new test cases for the new case. |
We are updating apps' apk path to have a two-level structure. Default apk path of an installed app: Before: /data/app/[packageName]-[randomString]/base.apk After: /data/app/[randomStringA]/[packageName]-[randomStringB]/base.apk This CL fixes the path guessing assumption the apk dir is only one level below the /data/app dir. Fixes linkedin#155.
|
Updated this PR. We found a bug in the previous version that didn't consider the case where there is dash in the random string. |
chao2zhang
approved these changes
Jan 29, 2020
| @@ -136,20 +136,31 @@ private static String processClassLoaderString43OrLater(String input) { | |||
|
|
|||
| File[] guessPath(String input) { | |||
| List<File> results = new ArrayList<>(); | |||
| String apkPathRoot = "/data/app/"; | |||
| for (String potential : splitPathList(input)) { | |||
There was a problem hiding this comment.
It would be better if we include the example path /data/app/[randomStringA]/[packageName]-[randomStringB]/base.apk as a comment.
chao2zhang
pushed a commit
to chao2zhang/dexmaker
that referenced
this pull request
Jun 2, 2020
drewhannay
pushed a commit
that referenced
this pull request
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are updating apps' apk path to have a two-level structure.
Default apk path of an installed app:
Before: /data/app/[packageName]-[randomString]/base.apk
After: /data/app/[randomStringA]/[packageName]-[randomStringB]/base.apk
This CL fixes the path guessing assumption the apk dir is only one level
below the /data/app dir.
Fixes #155.