Partial with parameters was not getting the correct context #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Maybe the decap/recap should be extracted so it can be used as a helper function? |
| @@ -10,7 +10,7 @@ | |||
| <script src="./dust_files/jsdump.js"></script> | |||
| <script src="./dust_files/beautify.js"></script> | |||
| <script src="../lib/dust.js"></script> | |||
| <script src="../dustjs-helpers/lib/dust-helpers.js"></script> | |||
| <script src="../lib/dust-helpers.js"></script> | |||
There was a problem hiding this comment.
Slipping this into the Pull request.
jimmyhchan
added a commit
that referenced
this pull request
Sep 7, 2012
Partial with parameters was not getting the correct context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Too many merge conflicts on the previous branch... let's try again
the logic before for putting the parameter onto the context stack was wrong.
Partials with parameters that had 2 levels of context were missing the last level and manifested itself as partials with parameters was not properly walking up the tree.
This is exacerbated by the
@sectioncalls which puts stuff on the stack