Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partials with parameters context was missing blocks #154

Merged
merged 1 commit into from
Sep 30, 2012
Merged

partials with parameters context was missing blocks #154

merged 1 commit into from
Sep 30, 2012

Conversation

jimmyhchan
Copy link
Contributor

d'oh. just need verification that this actually fixes the block problems.

Next step:

  • refactor to not use makebase.
  • add something like context.pop and do a funny dance to get the context correct using context.rebase (alternatively modify context.rebase to accept a tail)
  • fix @select to use the same context.pushUnderTheHead function

vybs added a commit that referenced this pull request Sep 30, 2012
@vybs
Merge pull request #154 from jimmyhchan/partialContextFix2
1e7e0a8 
partials with parameters context was missing blocks
@vybs vybs merged commit 1e7e0a8 into linkedin:master Sep 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmyhchan @vybs