pegjs 0.7 compatibility and parser variables removed from section function on dustjs file #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction on pegjs files, this makes the parser more independent.
|
a unrelated question can we use the --track-line-and-column isn't this useful for tracking line and column numbers. |
|
Hey Veena I have added the trackLineAndColumn to the parser, but it make that every test fails, i am not sure yet why but I am on it. |
|
sure thanks , the rest lgtm, we need to add a ticket to investigate rermoving cache=true ( as per David's comments for peg parser performance ) |
vybs
added a commit
that referenced
this pull request
May 8, 2012
pegjs 0.7 compatibility and parser variables removed from section function on dustjs file
sethkinast
pushed a commit
to sethkinast/dustjs
that referenced
this pull request
Mar 4, 2015
Quick CSS polish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes the parser more independent.