Add lines and columns to dust.pegjs #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding lines and columns to each significant node in dust.pegjs. The lines and columns are removed by filterAST before compilation begins. This will be useful for more detailed error reporting in applications like https://github.com/smfoote/Swiffer.js
|
lgtm |
|
|
||
| /*------------------------------------------------------------------------------------------------------------------------------------- | ||
| inline_part is defined as matching a special or reference or literal | ||
| ---------------------------------------------------------------------------------------------------------------------------------------*/ | ||
| inline_part | ||
| = special / reference / l:literal { return ["buffer", l] } | ||
| = special / reference / l:literal { return ["buffer", l].concat([['line', line], ['col', column]]) } | ||
|
|
||
| buffer "buffer" | ||
| = e:eol w:ws* | ||
| { return ["format", e, w.join('')] } |
added 5 commits
July 17, 2013 15:44
| @@ -1,5 +1,6 @@ | |||
| /nbproject | |||
| node_modules | |||
There was a problem hiding this comment.
this should be fine. please revert.
|
Good to merge otherwise |
I had attempted to change the .gitignore to remove a directory within node_modules/, but it turned out the .gitignore was correct. The directory had been force-added, so I had to remove it, which I did in a separate PR.
jimmyhchan
added a commit
that referenced
this pull request
Jul 24, 2013
Add lines and columns to dust.pegjs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding lines and columns to each significant node in dust.pegjs. The lines and columns are removed by filterAST before compilation begins.
This will be useful for more detailed error reporting in applications like https://github.com/smfoote/Swiffer.js